mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 12340: Reservations 1 - Add roles to Resources
Date Fri, 12 Jul 2013 02:12:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12340/#review23050
-----------------------------------------------------------

Ship it!



src/common/resources.hpp
<https://reviews.apache.org/r/12340/#comment46866>

    Can you move this either before or after the operators?



src/common/resources.hpp
<https://reviews.apache.org/r/12340/#comment46867>

    What about calling this 'flatten'? Seems like we need a "primitive" to refer to this both
in discussions and in code. Likewise, what about taking a 'role' parameter as the role name
to flatten all these resources into (rather than always the default '*').



src/common/resources.hpp
<https://reviews.apache.org/r/12340/#comment46868>

    Please add a TODO: Replace with 'allocatable'. ;)



src/common/resources.cpp
<https://reviews.apache.org/r/12340/#comment46869>

    s/matches (/matches(/



src/common/resources.cpp
<https://reviews.apache.org/r/12340/#comment46870>

    How about a 'break' here and remove the '&& !found' above?



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/12340/#comment46871>

    You should be able to fit the entire string on the next line:
    
    string output =
      "cpus=45.55 (*); ports=[10000-20000, 30000-50000] (*); disks={sda1} (*)";



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/12340/#comment46872>

    Woah, that's a bug!!!!!! Thanks for the fix!


- Benjamin Hindman


On July 8, 2013, 9:46 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12340/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 9:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-505
>     https://issues.apache.org/jira/browse/MESOS-505
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As part of the addition of reserved resources to the allocator, we decided to mark resources
with roles. This makes it easy for the allocator to track what reserved pool different resources
came from. This patch updates the current resource operators to consider roles, so for example
only resources with the same role will be added together.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 233e3c3 
>   src/common/resources.hpp 42dfb6a 
>   src/common/resources.cpp 8bc1057 
>   src/tests/resources_tests.cpp 67a11b3 
> 
> Diff: https://reviews.apache.org/r/12340/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message