mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 12254: Fixed master to not offer non-checkpointing slaves' resources to checkpointing frameworks.
Date Tue, 09 Jul 2013 01:20:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12254/#review22876
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/12254/#comment46620>

    Maybe a TODO about why we're not doing this in the allocator or at least a TODO to remove
this once all slaves checkpoint?


- Benjamin Hindman


On July 3, 2013, 7:34 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12254/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 7:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-538
>     https://issues.apache.org/jira/browse/MESOS-538
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f39aa942752cde1a531d76357492692a2c9edf8f 
>   src/slave/flags.hpp 94c393eb1b5c85894a395f87524c6d139ca3d49a 
>   src/tests/slave_recovery_tests.cpp b0843d72b076daa11eb95b337b705c2057029d29 
> 
> Diff: https://reviews.apache.org/r/12254/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*NonCheckpointingSlave*" --verbose
--gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message