mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 12283: Replace "mesosDate" with "isoDate"
Date Mon, 08 Jul 2013 16:36:54 GMT


> On July 8, 2013, 4:09 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/home.html, line 24
> > <https://reviews.apache.org/r/12283/diff/1/?file=318380#file318380line24>
> >
> >     Move </abbr> to next line to be consistent with others?
> 
> Ross Allen wrote:
>     Putting the closing tag on the same line is to prevent trailing spaces from being
underlined.
>     
>     In this example, the whitespace in the <abbr> is collapsed because there is
no more content inside the parent. "USA" is underlined:
>     
>     <div>
>       <abbr>
>         USA
>       </abbr>
>     </div>
>     
>     In this example, which matches the commented case, the browser interprets the whitespace
inside the <abbr> tag as meaningful. Since <abbr> has an underline in Bootstrap,
"USA " gets underlined with a trailing space:
>     
>     <div>
>       <abbr>
>         USA
>       </abbr>
>       is in the Northern hemisphere.
>     </div>

Awesome, thanks for the explanation!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12283/#review22823
-----------------------------------------------------------


On July 5, 2013, 10:55 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12283/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 10:55 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Dates now use HTML "title" attribute on <abbr> elements to let the browser do the
hover work. Bootstrap already styles <abbr> with a dashed underline.
> 
> This removes the blue color from dates since they are not navigation.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67 
>   src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110 
>   src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 
>   src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
>   src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d 
>   src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c 
> 
> Diff: https://reviews.apache.org/r/12283/diff/
> 
> 
> Testing
> -------
> 
> Viewed all pages with "isoDate" uses to confirm rendering.
> 
> Hovered over dates in on each page to confirm "title" attribute showed correct time.
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message