Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 978E410C24 for ; Wed, 26 Jun 2013 20:59:29 +0000 (UTC) Received: (qmail 56524 invoked by uid 500); 26 Jun 2013 20:59:29 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 56449 invoked by uid 500); 26 Jun 2013 20:59:29 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 56439 invoked by uid 99); 26 Jun 2013 20:59:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jun 2013 20:59:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 14B5C1CD139; Wed, 26 Jun 2013 20:59:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8042516073147268546==" MIME-Version: 1.0 Subject: Review Request 12119: Moved master/slave HTTP route handlers into inner class. From: "Benjamin Hindman" To: "Ben Mahler" Cc: "Benjamin Hindman" , "mesos" Date: Wed, 26 Jun 2013 20:59:21 -0000 Message-ID: <20130626205921.23541.12859@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/12119/ X-Sender: "Benjamin Hindman" Reply-To: "Benjamin Hindman" --===============8042516073147268546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12119/ ----------------------------------------------------------- Review request for mesos and Ben Mahler. Repository: mesos Description ------- BenM and I had briefly discussed this once. In the end this is less code and I much prefer the encapsulation! Diffs ----- src/Makefile.am 933743593d8de2fcc412d2f771a4cbc1e6fd2884 src/master/http.hpp 9eb0a31defbe15e32cbc8e611305f1d1bac80ced src/master/http.cpp 47471d6881fa1b101cdeb3fb48a59712490267e9 src/master/master.hpp 86c5232d57e9e86e13acf48b68f1e3cf23442495 src/master/master.cpp a0b862a4f825c00dec2b73f993fe58d8aa90812b src/slave/http.hpp 98014708b2f01b453ab9ab3bfc2eeebcf82b3529 src/slave/http.cpp e362c3033f098838bf4133a208fe6381134f4d09 src/slave/slave.hpp 3ac893309b49e23fffebb8118d427e5d89d61a86 src/slave/slave.cpp 9985f14467ca0aa7faf83e602e1d8f1c2219dfc0 Diff: https://reviews.apache.org/r/12119/diff/ Testing ------- make check Thanks, Benjamin Hindman --===============8042516073147268546==--