Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE4131096F for ; Fri, 21 Jun 2013 23:50:42 +0000 (UTC) Received: (qmail 29983 invoked by uid 500); 21 Jun 2013 23:50:42 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 29946 invoked by uid 500); 21 Jun 2013 23:50:42 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 29935 invoked by uid 99); 21 Jun 2013 23:50:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jun 2013 23:50:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B8BE1CCDA1; Fri, 21 Jun 2013 23:50:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3204922956756542414==" MIME-Version: 1.0 Subject: Re: Review Request: Added a log message in the master for tasks lost during slave removal. From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 21 Jun 2013 23:50:32 -0000 Message-ID: <20130621235032.32008.6288@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/12044/ X-Sender: "Vinod Kone" References: <20130621234011.32008.5540@reviews.apache.org> In-Reply-To: <20130621234011.32008.5540@reviews.apache.org> Reply-To: "Vinod Kone" --===============3204922956756542414== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12044/#review22288 ----------------------------------------------------------- src/master/master.cpp This is awkwardly placed. Why not print right after = if (framework !=3D NULL) ? = Also, you could do = LOG(INFO) << "Sending status update " << update << " due to removal of slave " << slave->id << " ( " << slave->info.hostname() << ")"; - Vinod Kone On June 21, 2013, 11:40 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12044/ > ----------------------------------------------------------- > = > (Updated June 21, 2013, 11:40 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > See bug description. > = > = > This addresses bug MESOS-503. > https://issues.apache.org/jira/browse/MESOS-503 > = > = > Diffs > ----- > = > src/master/master.cpp 60c6d4f88f8024796c5e495d7cc6ddde2b754887 = > = > Diff: https://reviews.apache.org/r/12044/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Ben Mahler > = > --===============3204922956756542414==--