Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6907223956632155595=="
MIME-Version: 1.0
Subject: Re: Review Request: WDRF 2 - Add concept of adding/removing roles
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Benjamin Hindman" <benh@berkeley.edu>
Cc: "Thomas Marshall" <twm378@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Wed, 12 Jun 2013 23:40:34 -0000
Message-ID: <20130612234034.1041.22098@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
References: <20130612175000.3611.78100@reviews.apache.org>
In-Reply-To: <20130612175000.3611.78100@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>

--===============6907223956632155595==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11206/
-----------------------------------------------------------

(Updated June 12, 2013, 11:40 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Added bug.


Description
-------

Previously when we were doing hierarchical allocation by user, we created a=
nd removed user pools for allocation based on what users had frameworks cur=
rently running in the cluster. However, with the role abstraction it makes =
sense to have more persistence than that, especially once we add weights - =
if you set the weight for a role, you want the allocator to remember it eve=
n if there aren't any frameworks for that role currently running.

So, I decided that it made sense to create a concept of specific roles that=
 are allowable in the cluster. With this patch, its only possible to pass r=
oles in to the master as a command line flag (to ease what I assume will be=
 the common case - clusters with relatively static sets of roles), but a fu=
ture wdrf patch will add http endpoints to add, remove, and update roles.

This patch also enforces that frameworks register with valid role (this won=
't affect people who don't care about roles, since there's always the "*" r=
ole, which is the default for frameworks that don't specify a role).


This addresses bug MESOS-504.
    https://issues.apache.org/jira/browse/MESOS-504


Diffs
-----

  include/mesos/mesos.proto 8cbcd9a =

  src/master/allocator.hpp 78c75bb =

  src/master/flags.hpp f4ce8c1 =

  src/master/hierarchical_allocator_process.hpp 1048a28 =

  src/master/master.hpp 86c5232 =

  src/master/master.cpp 60c6d4f =

  src/tests/allocator_tests.cpp 32f0a90 =

  src/tests/allocator_zookeeper_tests.cpp 1daaecd =

  src/tests/mesos.hpp fca41aa =

  src/tests/resource_offers_tests.cpp 3d5f02d =


Diff: https://reviews.apache.org/r/11206/diff/


Testing
-------

make check


Thanks,

Thomas Marshall


--===============6907223956632155595==--