mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 12182: Fixed a bug in master to properly remove a non checkpointing framework from a checkpointing slave.
Date Fri, 28 Jun 2013 23:09:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12182/#review22544
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/12182/#comment46254>

    kill newline? Or add a newline after the hashset declaration?



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/12182/#comment46253>

    Doesn't look like you need to store the tasks:
    
    tasks.push_back(createTask(offer1, "sleep 1000"))


- Ben Mahler


On June 28, 2013, 10:33 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12182/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 10:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-535
>     https://issues.apache.org/jira/browse/MESOS-535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4da8773c34d8bf6cb2defda61a00d2fd6f28bd4d 
>   src/tests/slave_recovery_tests.cpp 0195e688dac09b139c107e6815e0b842116c5e5c 
> 
> Diff: https://reviews.apache.org/r/12182/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Made sure the test broke before the fix in the master.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message