mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Added a log message in the master for tasks lost during slave removal.
Date Fri, 21 Jun 2013 23:50:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12044/#review22288
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/12044/#comment45777>

    This is awkwardly placed. Why not print right after 
    if (framework != NULL) ?
    
    Also, you could do
    
    LOG(INFO) << "Sending status update " << update
                     << " due to removal of slave " << slave->id
                     << " ( " << slave->info.hostname() << ")";


- Vinod Kone


On June 21, 2013, 11:40 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12044/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 11:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See bug description.
> 
> 
> This addresses bug MESOS-503.
>     https://issues.apache.org/jira/browse/MESOS-503
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 60c6d4f88f8024796c5e495d7cc6ddde2b754887 
> 
> Diff: https://reviews.apache.org/r/12044/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message