mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Kill tasks that never properly launch.
Date Thu, 20 Jun 2013 23:40:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11124/#review22210
-----------------------------------------------------------



hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11124/#comment45633>

    I think we'll need to add the 'volatile' keyword for any of these that are accessed by
the timer, right? My Java is a bit rusty.



hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11124/#comment45632>

    Can you instead do MesosTracker.this.active instead of storing the parent?


- Ben Mahler


On June 11, 2013, 8 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11124/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 8 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Kill tasks that never properly launch.
> 
> After trying to launch a task tracker, we'll wait up to 5 minutes before
> giving up and killing the task.
> 
> Review: https://reviews.apache.org/r/11124
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3

> 
> Diff: https://reviews.apache.org/r/11124/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 &&
make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message