mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Fixed slave to create work directory during initialization.
Date Thu, 20 Jun 2013 23:16:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12010/#review22208
-----------------------------------------------------------


I see why you added the helper, but it seems odd that it's only needed / used by initialization.
I realize initialize is fairly large, but my preference would be to keep it in there. Alternatively,
could the helper be static, taking as input the flags, and returning a Resources object?

- Ben Mahler


On June 20, 2013, 11:02 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12010/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 11:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d1ba82ed0c87331c6c06b109bbc2b267a07cf335 
>   src/slave/slave.cpp 952bd149247c2cc44b87d20fe63a45d011f5578b 
> 
> Diff: https://reviews.apache.org/r/12010/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message