mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Implemented a killtree utility (inspired by the killtree.sh script in mesos).
Date Wed, 19 Jun 2013 18:49:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11849/
-----------------------------------------------------------

(Updated June 19, 2013, 6:49 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebase, NNFR.


Description
-------

For how killtree will be used, see the killtree.sh script in mesos.

This version is actually more robust than killtree.sh, as it first stops the entire tree,
_then_ issues the signal.
Currently, killtree.sh stops, signals, and continues each process in isolation.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 2b7ee9c099a28dc5e482d7609e6307f2b6398e8b

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5

  3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 73b2336e93d6e5aac97e2c18e8e36c258c56a420


Diff: https://reviews.apache.org/r/11849/diff/


Testing
-------

Added a test, however this test can be _significantly_ cleaned up were we to create an abstraction
for generating process trees!


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message