mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Removed killtree.sh in favor of os::killtree from libstout.
Date Wed, 19 Jun 2013 18:33:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11853/
-----------------------------------------------------------

(Updated June 19, 2013, 6:33 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebase, NNFR.


Description
-------

killtree.sh has become a source of annoyance over time, the new os::killtree utility is written
in C++ and uses a more robust killing technique.

Also, killtree.sh on OSX had an issue with session ids from ps.


Diffs (updated)
-----

  bin/mesos-build-env.sh.in 31bccad3fab133dcb67670a2727b8ce433f62f70 
  src/Makefile.am 6491f5650e9d24d4a625a005e7a411169a2f0c9c 
  src/common/process_utils.hpp a04f4a203cea707c6c48e46f1303baf812a6c57c 
  src/launcher/executor.cpp 1a6725a8098d21bb813d66649257263b5e96136e 
  src/scripts/killtree.sh c42665476834f14f41bdcb2609bcc1baea44100c 
  src/slave/process_isolator.cpp b54bf7e81803863ea4eae26e43ceddda39fcf798 
  src/tests/environment.hpp 691291fcc0a9766de20292d63b82ec1c781b4e56 
  src/tests/environment.cpp 24227c531b2a750340343038228d558b65469bfc 
  src/tests/killtree_test.sh 396295470887ef8b36f1c5eb820a43ef95b5459e 
  src/tests/killtree_tests.cpp 753c5c07e0e17aa78646027b7b04419044cf20a2 
  src/tests/mesos.hpp fca41aae0b2cdc3ea5d10882c9c54809c3307266 
  src/tests/mesos.cpp 6dbf7f3dcd484ea0092f5690fb12ef350477f19c 
  src/tests/slave_recovery_tests.cpp 0315c524b2552e6a662fda7dfe58efa8c52f90de 

Diff: https://reviews.apache.org/r/11853/diff/


Testing
-------

make check on OSX and linux.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message