mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Implemented a killtree utility (inspired by the killtree.sh script in mesos).
Date Mon, 17 Jun 2013 18:13:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11849/#review21994
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp
<https://reviews.apache.org/r/11849/#comment45313>

    s/Dec/dec/


- Benjamin Hindman


On June 12, 2013, 7:49 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11849/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 7:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> For how killtree will be used, see the killtree.sh script in mesos.
> 
> This version is actually more robust than killtree.sh, as it first stops the entire tree,
_then_ issues the signal.
> Currently, killtree.sh stops, signals, and continues each process in isolation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f

> 
> Diff: https://reviews.apache.org/r/11849/diff/
> 
> 
> Testing
> -------
> 
> Added a test, however this test can be _significantly_ cleaned up were we to create an
abstraction for generating process trees!
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message