mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: WDRF 5 - Adds tests for roles and WDRF
Date Wed, 12 Jun 2013 23:15:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/#review21821
-----------------------------------------------------------

Ship it!



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45026>

    s/and/an/



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45027>

    s/, as well as added, removed, and updated through the http endpoints//



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45028>

    Shutdown();


- Benjamin Hindman


On June 5, 2013, 9:48 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11214/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 9:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to
test roles.
> 
> Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
> 
> Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm
correctly.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 32f0a90 
>   src/tests/sorter_tests.cpp 0a50b43 
> 
> Diff: https://reviews.apache.org/r/11214/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message