mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Added generic process utilities to libstout.
Date Tue, 11 Jun 2013 21:20:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11092/
-----------------------------------------------------------

(Updated June 11, 2013, 9:20 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Updated Process comparison operators to be const.


Description
-------

These were reviewed by benh, and I'm sending these out in a new chain as the old chain no
longer made sense.

Old reviews:
https://reviews.apache.org/r/10895/
https://reviews.apache.org/r/10896/
https://reviews.apache.org/r/10897/
https://reviews.apache.org/r/10898/
https://reviews.apache.org/r/10899/


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 84062a0e1dfe4ec04bac7cac5ebaac4b945eb66e

  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp c1a05b58cbe1d0a9d006dec2db47d147149d421b

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp b59735fbe993839aae3cb9ca7871517798c4cd46

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f

  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 2305ef53b700d5092802eab6f54a2893f5622e02


Diff: https://reviews.apache.org/r/11092/diff/


Testing
-------

Added tests, make check on OSX and Linux.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message