mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Terminate executors that aren't needed.
Date Thu, 06 Jun 2013 22:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11125/#review21544
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp
<https://reviews.apache.org/r/11125/#comment44588>

    s/ && executor->launchedTasks.empty()//
    
    You can in fact CHECK(executor->launchedTasks.empty()) since a REGISTERING executor
should never have any launched tasks.


- Ben Mahler


On June 6, 2013, 2:10 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11125/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 2:10 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Terminate executors that aren't needed.
> 
> If we launch an executor and then kill the task immediately after, make
> sure we also terminate the executor when there are no other tasks.
> 
> Review: https://reviews.apache.org/r/11125
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 8ce1646f2f804bc8dc20506d11078191f0274654 
> 
> Diff: https://reviews.apache.org/r/11125/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message