mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fixed Zookeeper master detector to only create zookeeper paths when it is contending.
Date Wed, 05 Jun 2013 18:16:41 GMT


> On June 4, 2013, 12:53 a.m., Ben Mahler wrote:
> > src/zookeeper/zookeeper.cpp, line 559
> > <https://reviews.apache.org/r/11366/diff/7/?file=300149#file300149line559>
> >
> >     Well, deletion seems dangerous in the face of many detectors operating at once
on the same path, no?
> 
> Vinod Kone wrote:
>     good point. this is tricky, thats why it is a TODO :). may be this function needs
to be synchronized to guard against multiple callers. will update the TODO.

You'd need synchronization across callers in the same process and callers in different processes
(on different machines). And even if you could (or wanted to) orchestrate that, you could
still have the rouge process (or ops guy) do some unsynchronized deletes. Ugh.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11366/#review21389
-----------------------------------------------------------


On June 4, 2013, 1:13 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11366/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 1:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and Raul Gutierrez
Segales.
> 
> 
> Description
> -------
> 
> This is likely a short term fix pending Yan's refactor of detector.
> 
> 2 changes:
> 1) Fixed a bug in zookeeper->create().
> 2) Removed create for non-contending detectors.
> 
> 
> This addresses bug mesos-409.
>     https://issues.apache.org/jira/browse/mesos-409
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b 
>   src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 
>   src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 
> 
> Diff: https://reviews.apache.org/r/11366/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message