Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A7E3EB94 for ; Thu, 30 May 2013 04:25:19 +0000 (UTC) Received: (qmail 46232 invoked by uid 500); 30 May 2013 04:25:18 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 46033 invoked by uid 500); 30 May 2013 04:25:14 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 45971 invoked by uid 99); 30 May 2013 04:25:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 May 2013 04:25:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3D0261CBDF9; Thu, 30 May 2013 04:25:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7097966556065255539==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed Zookeeper master detector to only create zookeeper paths when it is contending. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" , "Bill Farner" , "Raul Gutierrez Segales" Cc: "Vinod Kone" , "mesos" Date: Thu, 30 May 2013 04:25:06 -0000 Message-ID: <20130530042506.1390.3131@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11366/ X-Sender: "Vinod Kone" References: <20130530035241.1348.23580@reviews.apache.org> In-Reply-To: <20130530035241.1348.23580@reviews.apache.org> Reply-To: "Vinod Kone" --===============7097966556065255539== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On May 30, 2013, 3:52 a.m., Raul Gutierrez Segales wrote: > > src/zookeeper/zookeeper.cpp, line 533 > > > > > > Why not os::dirname? (sure there is a good reason, just curious) dirname("/a/b/") returns "/a". We want "/a/b". Makes sense? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review21171 ----------------------------------------------------------- On May 30, 2013, 3:44 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > = > (Updated May 30, 2013, 3:44 a.m.) > = > = > Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and = Raul Gutierrez Segales. > = > = > Description > ------- > = > This is likely a short term fix pending Yan's refactor of detector. > = > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > = > = > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > = > = > Diffs > ----- > = > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e = > src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b = > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 = > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 = > = > Diff: https://reviews.apache.org/r/11366/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============7097966556065255539==--