Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B06910AAB for ; Mon, 6 May 2013 19:04:01 +0000 (UTC) Received: (qmail 71909 invoked by uid 500); 6 May 2013 19:04:01 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 71866 invoked by uid 500); 6 May 2013 19:04:00 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 71851 invoked by uid 99); 6 May 2013 19:04:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 May 2013 19:04:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B3BF41C95DF; Mon, 6 May 2013 19:03:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8356242239737732518==" MIME-Version: 1.0 Subject: Re: Review Request: Terminate executors that aren't needed. From: "Brenden Matthews" To: "Vinod Kone" , "Ben Mahler" , "mesos" , "Brenden Matthews" Date: Mon, 06 May 2013 19:03:56 -0000 Message-ID: <20130506190356.5514.96815@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brenden Matthews" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10932/ X-Sender: "Brenden Matthews" References: <20130503184256.17259.8397@reviews.apache.org> In-Reply-To: <20130503184256.17259.8397@reviews.apache.org> Reply-To: "Brenden Matthews" --===============8356242239737732518== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10932/ ----------------------------------------------------------- (Updated May 6, 2013, 7:03 p.m.) Review request for mesos. Changes ------- @ Ben: Is this what you had in mind? Description ------- >From 607072595b91993e2d47251ee841fb3dc5d84e05 Mon Sep 17 00:00:00 2001 From: Brenden Matthews Date: Fri, 3 May 2013 09:47:22 -0700 Subject: [PATCH 8/9] Terminate executors that aren't needed. If we launch an executor and then kill the task immediately after, make sure we also terminate the executor when there are no other tasks. --- src/slave/slave.cpp | 48 +++++++++++++++++++++++++++--------------------- 1 file changed, 27 insertions(+), 21 deletions(-) Diffs (updated) ----- include/mesos/executor.hpp 9b25834 = src/exec/exec.cpp 1f022ca = Diff: https://reviews.apache.org/r/10932/diff/ Testing ------- Used in production at airbnb. Thanks, Brenden Matthews --===============8356242239737732518==--