Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AD68F7BD for ; Thu, 2 May 2013 19:30:24 +0000 (UTC) Received: (qmail 13270 invoked by uid 500); 2 May 2013 19:30:24 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 13252 invoked by uid 500); 2 May 2013 19:30:24 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 13239 invoked by uid 99); 2 May 2013 19:30:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 19:30:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 34BB91C9465; Thu, 2 May 2013 19:30:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1450429040975232272==" MIME-Version: 1.0 Subject: Re: Review Request: Implemented 'lsr' function to recursively list directory entries. From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Thu, 02 May 2013 19:30:19 -0000 Message-ID: <20130502193019.17258.45488@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10905/ X-Sender: "Ben Mahler" References: <20130502190926.17260.62751@reviews.apache.org> In-Reply-To: <20130502190926.17260.62751@reviews.apache.org> Reply-To: "Ben Mahler" --===============1450429040975232272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On May 2, 2013, 7:09 p.m., Benjamin Hindman wrote: > > Can we not do the same thing right now with find? > = > Vinod Kone wrote: > I thought about it. But felt that using find(directory, "") is a hack= . Mainly because we would be relying on the implementation of 'find' to ret= urn results in post-order walk. But 'lsr' doesn't seem to suggest a post-order walk, it seems it is communi= cated through your comment: // Returns a list of directory entries (including the given directory) // recursively collected through a post-order traversal. Couldn't find() have a similar comment? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10905/#review20092 ----------------------------------------------------------- On May 2, 2013, 6:54 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10905/ > ----------------------------------------------------------- > = > (Updated May 2, 2013, 6:54 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > First step in doing a rate limited gc. > = > = > Diffs > ----- > = > third_party/libprocess/third_party/stout/include/stout/os.hpp c71ae9ed3= 2af2a14dc7b9b34521cb5ea6025235c = > third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05eb= bbefd85e4a163dbb6ab8445edfb7f = > = > Diff: https://reviews.apache.org/r/10905/diff/ > = > = > Testing > ------- > = > sudo ./third_party/libprocess/third_party/stout-tests --gtest_filter=3D"*= lsr*" --verbose --gtest_repeat=3D1000 --gtest_break_on_failure > = > = > Thanks, > = > Vinod Kone > = > --===============1450429040975232272==--