Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6CEBDFC50 for ; Thu, 2 May 2013 01:54:31 +0000 (UTC) Received: (qmail 31470 invoked by uid 500); 2 May 2013 01:54:31 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 31452 invoked by uid 500); 2 May 2013 01:54:31 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 31439 invoked by uid 99); 2 May 2013 01:54:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 01:54:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4D1581C932C; Thu, 2 May 2013 01:54:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4760110984404970566==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed process isolator to safely setup launcher's environment. From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Thu, 02 May 2013 01:54:27 -0000 Message-ID: <20130502015427.17258.48486@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10879/ X-Sender: "Ben Mahler" References: <20130501032902.17259.92514@reviews.apache.org> In-Reply-To: <20130501032902.17259.92514@reviews.apache.org> Reply-To: "Ben Mahler" --===============4760110984404970566== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10879/#review20044 ----------------------------------------------------------- Ship it! Any chance of a similar fix for the CgroupIsolator? - Ben Mahler On May 1, 2013, 3:29 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10879/ > ----------------------------------------------------------- > = > (Updated May 1, 2013, 3:29 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > This hopefully reduces (eliminates?) the chance that a process isolator d= eadlocks on ostringstream between a fork and exec. > = > = > This addresses bug MESOS-393. > https://issues.apache.org/jira/browse/MESOS-393 > = > = > Diffs > ----- > = > src/launcher/launcher.hpp 9f0e247978d1609c3ad564ade2b528d3e04a9b9f = > src/launcher/launcher.cpp 11cffc915f2e9218aae8ed6b9d19ed82a4e2ea66 = > src/launcher/main.cpp 57d671e7ee6e88429ead0a257b3545676a896ffd = > src/slave/process_isolator.cpp 6938fbcca9d384bb014ff4dd52a13763c1f8397a = > = > Diff: https://reviews.apache.org/r/10879/diff/ > = > = > Testing > ------- > = > make check on OSX and CentOS. > = > = > Thanks, > = > Vinod Kone > = > --===============4760110984404970566==--