mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brenden Matthews" <bren...@diddyinc.com>
Subject Re: Review Request: Ignore errors from post-review.
Date Tue, 28 May 2013 22:19:03 GMT


> On May 17, 2013, 7:43 p.m., Vinod Kone wrote:
> > support/post-reviews.py, lines 151-168
> > <https://reviews.apache.org/r/11160/diff/1/?file=291864#file291864line151>
> >
> >     Hmm. Are you still seeing issues with post-reviews? If not, lets discard this.
We wan't to catch errors!

I'm still struggling to get post-reviews to work.  It could be that I'm bad at using it.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11160/#review20728
-----------------------------------------------------------


On May 14, 2013, 5:58 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11160/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From 80f280af52a7256dec0b8e273791f531634de9dc Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <brenden.matthews@airbnb.com>
> Date: Tue, 14 May 2013 10:22:56 -0700
> Subject: [PATCH 5/5] Ignore errors from post-review.
> 
> When updating existing reviews, post-review returns errors erroneously.
> 
> Review: https://reviews.apache.org/r/11160
> ---
>  support/post-reviews.py |   13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1 
> 
> Diff: https://reviews.apache.org/r/11160/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message