mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fixed Zookeeper master detector to only create zookeeper paths when it is contending.
Date Fri, 24 May 2013 01:52:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11366/#review20975
-----------------------------------------------------------



src/detector/detector.cpp
<https://reviews.apache.org/r/11366/#comment43370>

    Woah. I was just expecting ZooKeeper::create to first do an exists on the path, only attempting
to create it if it doesn't exist. Why is that not sufficient? I'm not actually convinced the
changes you make are correct, see comments below.



src/detector/detector.cpp
<https://reviews.apache.org/r/11366/#comment43372>

    I don't know what you mean by "Try again when we reconnect.". If I understand correctly
if we get a ZNONODE we won't have put a watch in place which means we'll just sit idle until
we reconnect, which could be a very long time.


- Benjamin Hindman


On May 24, 2013, 1:03 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11366/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 1:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Description
> -------
> 
> This is likely a short term fix pending Yan's refactor of detector.
> 
> 2 changes:
> 1) Fixed a bug in zookeeper->create().
> 2) Removed create for non-contending detectors.
> 
> 
> This addresses bug mesos-409.
>     https://issues.apache.org/jira/browse/mesos-409
> 
> 
> Diffs
> -----
> 
>   src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 
>   src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 
>   src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 
> 
> Diff: https://reviews.apache.org/r/11366/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message