mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Terminate executors that aren't needed.
Date Fri, 03 May 2013 19:37:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10932/#review20136
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/10932/#comment41389>

    this seems like the wrong thing to do. an executor can run more than one task. why do
you want to kill the executor if it could get more tasks?


- Vinod Kone


On May 3, 2013, 6:42 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10932/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 6:42 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From 607072595b91993e2d47251ee841fb3dc5d84e05 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <brenden.matthews@airbnb.com>
> Date: Fri, 3 May 2013 09:47:22 -0700
> Subject: [PATCH 8/9] Terminate executors that aren't needed.
> 
> If we launch an executor and then kill the task immediately after, make
> sure we also terminate the executor when there are no other tasks.
> ---
>  src/slave/slave.cpp |   48 +++++++++++++++++++++++++++---------------------
>  1 file changed, 27 insertions(+), 21 deletions(-)
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 86a15fc 
> 
> Diff: https://reviews.apache.org/r/10932/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message