Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD50DF368 for ; Thu, 25 Apr 2013 18:43:57 +0000 (UTC) Received: (qmail 23614 invoked by uid 500); 25 Apr 2013 18:43:57 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 23588 invoked by uid 500); 25 Apr 2013 18:43:57 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 23578 invoked by uid 99); 25 Apr 2013 18:43:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 18:43:57 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of benjamin.mahler@gmail.com designates 209.85.128.181 as permitted sender) Received: from [209.85.128.181] (HELO mail-ve0-f181.google.com) (209.85.128.181) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2013 18:43:52 +0000 Received: by mail-ve0-f181.google.com with SMTP id d10so1424101vea.40 for ; Thu, 25 Apr 2013 11:43:31 -0700 (PDT) X-Received: by 10.52.69.109 with SMTP id d13mr1286382vdu.75.1366915411660; Thu, 25 Apr 2013 11:43:31 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPSA id a17sm2378248vdj.2.2013.04.25.11.43.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Apr 2013 11:43:30 -0700 (PDT) Received: by mail-vc0-f179.google.com with SMTP id hz10so588209vcb.10 for ; Thu, 25 Apr 2013 11:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=6Y4VQAELLUVhuj7shOwHGw18bmH2wYwGXpPJd/wKg1c=; b=nxyFCGafxqjrYeKurPzloUCQE9H4CYWWNT3C/FYZug6uewy7hKBrXUCjYMNThnRLak 5vFT8Gv2ZT9wPQ5RS+TlBQqSrfzyEb/K4u3oJz/GtT7fr/yVyEsxa2FX7J1096rpT2dO VxHV6KMoZRQoBe/KnZ52FuASrhJJoif8U4aiFFJvLPC85kJEZPxHyBFqtrJsuHUF8OWq TgCJS2cgIMEmQ9dKR7ujgerwZRSWJecR58q58QjN39nXwQOY3/Nd3aEvof33bImv9IZU iTGqVbw/pt6ySWy4MrzlWkpeRdWa5+VGDt//3PszNnJhZ632dTrGB1c7brOMwS19IL// AI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=6Y4VQAELLUVhuj7shOwHGw18bmH2wYwGXpPJd/wKg1c=; b=I8YIU8iclxvZSTyTOl+ewmfEOljsRQAYgDwxN1n4he7oiPfL4bRkcVy11TZFmp0Rnz QGhNKrXOb70HCV8w+xSo227C92oizTpB4Gm0/bVQGCKhl5WegSefYtXlYnb7v+abQWvY MtxAVQKIFL3uvv15L2kJ46A82mG2OU4fc/Aa0OTOHIcrcFayFmKa24J1bdvArZjmunAc hFXjOS/jfUMeT9EFG11+A/EMdoqA6KTRxiqofnH4dpy5ZPbcN7jTkdbEe8nO3xf3iwxy ZxsojvKDQ2y1nGX89Fl8L9st8KCIDkt0jLwgyhK8C32H1RlZW89ExCioKMI37n3orAch 8DGA== X-Received: by 10.52.37.4 with SMTP id u4mr5068957vdj.54.1366915410195; Thu, 25 Apr 2013 11:43:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.168.5 with HTTP; Thu, 25 Apr 2013 11:43:10 -0700 (PDT) In-Reply-To: References: From: Benjamin Mahler Date: Thu, 25 Apr 2013 11:43:10 -0700 Message-ID: Subject: Re: Reaper related changes To: Yan Xu Cc: Vinod Kone , Benjamin Mahler , Benjamin Hindman , "mesos-dev@incubator.apache.org" Content-Type: multipart/alternative; boundary=20cf307d0284768a4904db33cb6c X-Gm-Message-State: ALoCoQlQsTL7sYv6uEXeREpVCcwl25yc2pDL6y4ETm1FrmJ/lXPc8GDHScd5j/+56FN0f/Adyvf4 X-Virus-Checked: Checked by ClamAV on apache.org --20cf307d0284768a4904db33cb6c Content-Type: text/plain; charset=ISO-8859-1 We also have a src/common/process_utils.hpp which contains only mesos::internal::utils::process::killtree() at the moment. On Thu, Apr 25, 2013 at 11:37 AM, Yan Xu wrote: > I guess os:: is fine, but in a separate file? > > -- > Jiang Yan Xu @xujyan > > > On Thu, Apr 25, 2013 at 11:29 AM, Vinod Kone wrote: > >> I don't like process:: because it conflicts with the libprocess namespace >> as you mentioned. >> >> I still like proc:: but clearly BenH doesn't like it. I'm ok with os:: >> namespace. >> >> >> @vinodkone >> >> >> On Thu, Apr 25, 2013 at 11:19 AM, Benjamin Mahler < >> benjamin.mahler@gmail.com> wrote: >> >>> Is there any consensus on how to place process utilities in stout? I >>> would expect this to be in a process:: namespace but of course that is >>> confusing because we use libprocess, which should perhaps have a >>> libprocess:: namespace instead.. >>> >>> I'll be moving process utilities etc into stout, hopefully with the same >>> calls for linux and OSX but I'm not yet certain if that is possible. I >>> would like to place these in a process.hpp file inside a process:: >>> namespace. >>> >>> I think these read very nicely: >>> process::alive(pid_t) >>> process::children(pid_t) >>> process::stat(pid_t) >>> >>> Thoughts? >>> >>> >>> On Tue, Apr 23, 2013 at 6:29 PM, Yan Xu wrote: >>> >>>> This batch of commits changed the reaper to use "Future" as the >>>> notification mechanism. >>>> >>>> Sequence: >>>> https://reviews.apache.org/r/10744/ >>>> https://reviews.apache.org/r/10745/ >>>> https://reviews.apache.org/r/10746/ >>>> https://reviews.apache.org/r/10747/ >>>> >>>> Best, >>>> Yan >>>> -- >>>> Jiang Yan Xu @xujyan >>>> >>> >>> >> > --20cf307d0284768a4904db33cb6c--