Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56A11F004 for ; Mon, 8 Apr 2013 22:31:23 +0000 (UTC) Received: (qmail 43929 invoked by uid 500); 8 Apr 2013 22:31:23 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 43859 invoked by uid 500); 8 Apr 2013 22:31:23 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 43845 invoked by uid 99); 8 Apr 2013 22:31:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2013 22:31:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DEB1F1C1977; Mon, 8 Apr 2013 22:31:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3882784166271405191==" MIME-Version: 1.0 Subject: Review Request: Fixed a deadlock in the Hadoop MesosScheduler by unsynchronizing resourceOffers(). From: "Ben Mahler" To: "Benjamin Hindman" , "Brenden Matthews" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Mon, 08 Apr 2013 22:31:20 -0000 Message-ID: <20130408223120.13837.74486@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10352/ X-Sender: "Ben Mahler" Reply-To: "Ben Mahler" --===============3882784166271405191== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10352/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman, Vinod Kone, and Brenden Matthew= s. Description ------- See my comments in the diff. The benefit of this solution is that the only modification needed is to uns= ynchronize resourceOffers() and pull out the needed JobTracker data prior t= o synchronizing explicitly. Longer term we will want to consider something = more robust against regressions. This addresses bug MESOS-429. https://issues.apache.org/jira/browse/MESOS-429 Diffs ----- hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 50df62= 5c914c158b368b71cf3e32428fbc637ad4 = Diff: https://reviews.apache.org/r/10352/diff/ Testing ------- Ran the tutorial for both of the supported Hadoop distributions. Thanks, Ben Mahler --===============3882784166271405191==--