mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request: Changed reaper to use Future as the notification mechanism. The notification is now sent only if the pid is explicitly registered via the monitor() call.
Date Tue, 30 Apr 2013 18:38:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10746/
-----------------------------------------------------------

(Updated April 30, 2013, 6:38 p.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

#include<stout/proc.hpp> -> #include <stout/os.hpp> in reaper_tests.cpp.


Description
-------

See summary.

- Previously the listener was notified when its child processes terminate whether it register
them or not. 


Diffs (updated)
-----

  src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed 
  src/slave/cgroups_isolator.cpp f12fd48fe739015429a3fe51cc8dce366ec4a483 
  src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
  src/slave/process_isolator.cpp 6938fbcca9d384bb014ff4dd52a13763c1f8397a 
  src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
  src/slave/reaper.cpp b4d8912fa4a5910b0003c06b87a7fbc6164a6382 
  src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 
  src/tests/utils.hpp ca3ecd7f0cab283327bf83e57d4b405b4ada9c74 

Diff: https://reviews.apache.org/r/10746/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message