mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request: Refactored Reaper with an abstraction that hides the dispatching syntax.
Date Tue, 30 Apr 2013 01:15:09 GMT


> On April 29, 2013, 5:49 p.m., Ben Mahler wrote:
> > src/slave/reaper.cpp, line 49
> > <https://reviews.apache.org/r/10744/diff/2/?file=285025#file285025line49>
> >
> >     Looks like this destructor is not necessary?
> 
> Jiang Yan Xu wrote:
>     Thanks for the examples above, I think I should discard all the futures the same
way GarbageCollectorProcess does it?
>     
>     GarbageCollectorProcess::~GarbageCollectorProcess()
>     {
>       foreachvalue (const PathInfo& info, paths) {
>         info.promise->future().discard();
>       }
>     }
> 
> Jiang Yan Xu wrote:
>     I am sorry the clean-up is in the Process class, not the wrapper. I'll delete the
destructor.
> 
> Jiang Yan Xu wrote:
>     Clearly I wasn't awake yet... Ignore the last reply. 
>     I am adding promise.future().discard()s to the ReaperProcess destructor.

Killed the destructor.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10744/#review19871
-----------------------------------------------------------


On April 30, 2013, 1:15 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10744/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 1:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 
>   src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 
>   src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
>   src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 
>   src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
>   src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 
>   src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 
> 
> Diff: https://reviews.apache.org/r/10744/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message