mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request: Refactored Reaper with an abstraction that hides the dispatching syntax.
Date Mon, 29 Apr 2013 18:08:31 GMT


> On April 29, 2013, 5:49 p.m., Ben Mahler wrote:
> > src/slave/reaper.hpp, lines 42-64
> > <https://reviews.apache.org/r/10744/diff/2/?file=285024#file285024line42>
> >
> >     Can you move this under Reaper?
> >     
> >     If exposing the underlying Process in the header, we typically place it below
the API, e.g.:
> >     src/slave/gc.hpp
> >     src/slave/monitor.hpp

This was addressed in https://reviews.apache.org/r/10746/.


> On April 29, 2013, 5:49 p.m., Ben Mahler wrote:
> > src/slave/reaper.cpp, line 49
> > <https://reviews.apache.org/r/10744/diff/2/?file=285025#file285025line49>
> >
> >     Looks like this destructor is not necessary?

Thanks for the examples above, I think I should discard all the futures the same way GarbageCollectorProcess
does it?

GarbageCollectorProcess::~GarbageCollectorProcess()
{
  foreachvalue (const PathInfo& info, paths) {
    info.promise->future().discard();
  }
}


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10744/#review19871
-----------------------------------------------------------


On April 26, 2013, 7:50 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10744/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 7:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 
>   src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 
>   src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
>   src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 
>   src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 
> 
> Diff: https://reviews.apache.org/r/10744/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message