mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Added an optional default value for Option::get().
Date Mon, 29 Apr 2013 17:14:28 GMT


> On April 29, 2013, 5:13 p.m., Benjamin Hindman wrote:
> > Ship It!

Also, if you know of places in the code base that can already benefit from this, please make
those changes. It's more likely people will use this if/when they see examples in the code.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/#review19867
-----------------------------------------------------------


On April 25, 2013, 9:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10717/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 9:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca

> 
> Diff: https://reviews.apache.org/r/10717/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message