mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Fixed the master to shutdown deactivated slaves that send further messages to the master.
Date Thu, 25 Apr 2013 21:37:58 GMT


> On April 25, 2013, 7:23 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, lines 594-598
> > <https://reviews.apache.org/r/10734/diff/1-2/?file=283422#file283422line594>
> >
> >     Should these be re-ordered?

Why? The shutdown message to the slave is sent first.


> On April 25, 2013, 7:23 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, lines 486-492
> > <https://reviews.apache.org/r/10734/diff/1-2/?file=283422#file283422line486>
> >
> >     I wonder if we should move part of this excellent comment up into the master
where we actually send shutdowns. Seems more useful to have it up there?
> >     
> >     Ditto, for the above test comment.

Both locations have this comment currently:

      // If the slave is deactivated, we have already informed
      // frameworks that its tasks were LOST, so the slave should
      // shut down.

Seems sufficient to me, no? Did you want the network partition scenario explained there as
an example possibility?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10734/#review19714
-----------------------------------------------------------


On April 25, 2013, 1:10 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10734/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 1:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See MESOS-446.
> 
> 
> This addresses bug MESOS-446.
>     https://issues.apache.org/jira/browse/MESOS-446
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
>   src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 
>   src/tests/fault_tolerance_tests.cpp d3476f7f5d1b7e2ed45385f5145eaccd6c114d21 
> 
> Diff: https://reviews.apache.org/r/10734/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message