mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Improved documentation of the proc::alive function. (libstout)
Date Thu, 25 Apr 2013 00:30:43 GMT


> On April 24, 2013, 11:55 p.m., Jiang Yan Xu wrote:
> > third_party/libprocess/third_party/stout/include/stout/proc.hpp, line 40
> > <https://reviews.apache.org/r/10745/diff/1/?file=283953#file283953line40>
> >
> >     Since it doesn't check for termination but rather validity (including dead/zombie
processes) of a PID, we should probably call it valid instead of alive to avoid confusion,
right?

i'm not particularly worried, but i will let you make the call.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10745/#review19682
-----------------------------------------------------------


On April 24, 2013, 12:31 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10745/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 12:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46

> 
> Diff: https://reviews.apache.org/r/10745/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message