mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Build fix for HadoopPipes.cc with GCC 4.7.
Date Fri, 19 Apr 2013 23:36:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10560/#review19495
-----------------------------------------------------------


Great, I can see the diff now! :)


hadoop/HadoopPipes.cc.patch
<https://reviews.apache.org/r/10560/#comment40237>

    Looks like this patch was generated for hadoop-2.0.0-mr1-cdh4.2.0 and it also happens
to work for hadoop-2.0.0-mr1-cdh4.1.2.
    
    Is it possible to combine this patch inside the existing patches:
    
      hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch
      hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch
    
    That way we isolate the required patches per-release and don't have to introduce another
patch file.


- Ben Mahler


On April 19, 2013, 10:57 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10560/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 10:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Build fix for HadoopPipes.cc with GCC 4.7.
> 
> 
> Diffs
> -----
> 
>   hadoop/HadoopPipes.cc.patch PRE-CREATION 
>   hadoop/Makefile.am ceac085 
>   hadoop/TUTORIAL.sh d81c555 
> 
> Diff: https://reviews.apache.org/r/10560/diff/
> 
> 
> Testing
> -------
> 
> Used it production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message