mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brenden Matthews" <bren...@diddyinc.com>
Subject Re: Review Request: Fix Hadoop classpath for tutorial & deployment.
Date Thu, 18 Apr 2013 01:08:43 GMT


> On April 17, 2013, 12:17 a.m., Vinod Kone wrote:
> > hadoop/TUTORIAL.sh, line 581
> > <https://reviews.apache.org/r/10489/diff/2/?file=281681#file281681line581>
> >
> >     So this is not the default? I wonder how it worked for us before?

I'm actually not sure if this is necessary.  I added it to be sure that $HADOOP_HOME was set
correctly and then forgot to remove it.  It may not be required after all.


> On April 17, 2013, 12:17 a.m., Vinod Kone wrote:
> > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch, line 10
> > <https://reviews.apache.org/r/10489/diff/2/?file=281684#file281684line10>
> >
> >     hmm..so you need to explicitly specify them for cdh4 but not for cdh3 and apache
hadoop?
> >     
> >     thats confusing. i would suggest reverting these changes in that case.

This was a mistake.  I've fixed the other patches as well.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10489/#review19286
-----------------------------------------------------------


On April 18, 2013, 1:08 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10489/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 1:08 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Fix Hadoop classpath for tutorial & deployment.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
>   hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch fb8b06b 
>   hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch 8f67ff9 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch 6d31578 
>   hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch 908ae4a 
> 
> Diff: https://reviews.apache.org/r/10489/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message