mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Build fix for GCC 4.7.
Date Wed, 17 Apr 2013 17:46:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10561/#review19334
-----------------------------------------------------------



third_party/libprocess/third_party/stout/include/stout/multimap.hpp
<https://reviews.apache.org/r/10561/#comment40012>

    For consistency, can you s/this->/std::multimap<K, V>::/ as done elsewhere?
    
    Otherwise, if you prefer to change the other spots to use 'this->' that's fine as well.


- Ben Mahler


On April 16, 2013, 10:06 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10561/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 10:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Build fix for GCC 4.7.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/multimap.hpp 8f0f803 
> 
> Diff: https://reviews.apache.org/r/10561/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message