mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Disable CgroupsNoHierarchy test when a hierarchy is mounted
Date Tue, 16 Apr 2013 21:06:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10531/#review19271
-----------------------------------------------------------


Ah I like this better, but I think we should continue to create prefixes that are composed
(as my comments below suggest).


src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/10531/#comment39905>

    s/CGROUPSNOHIERARCHY/ROOT_CGROUPS_NOHIERARCHY/



src/tests/environment.cpp
<https://reviews.apache.org/r/10531/#comment39907>

    s/CGROUPSNOHIERARCHY_/NOHIERARCHY_/
    
    And adjust the comment to reflect that the presence of NOHIERARCHY_ simply disables the
test if a cgroups hierarchy is mounted.
    
    This way, people can compose these prefixes, as was the original intent.



src/tests/environment.cpp
<https://reviews.apache.org/r/10531/#comment39908>

    Why the TODO? This is already checked inside the CgroupsNoHierarchyTest::SetUpTestCase..?



src/tests/environment.cpp
<https://reviews.apache.org/r/10531/#comment39911>

    s/CGROUPSNOHIERARCHY_/NOHIERARCHY_/



src/tests/environment.cpp
<https://reviews.apache.org/r/10531/#comment39912>

    Kill this check, users should instead compose the prefixes if they want ROOT user and
CGROUPS support.


- Ben Mahler


On April 16, 2013, 6:40 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10531/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 6:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> I know that I'm not assigned to this issue, but its causing about 75% of the test failures
that we're seeing in the AMP lab's Jenkins now, so I figured I would tackle it:
> 
> 
> This addresses bug MESOS-414.
>     https://issues.apache.org/jira/browse/MESOS-414
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 34ae0d2 
>   src/tests/environment.cpp 3096e5a 
> 
> Diff: https://reviews.apache.org/r/10531/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message