mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brenden Matthews" <bren...@diddyinc.com>
Subject Re: Review Request: Hadoop changes; see below.
Date Mon, 15 Apr 2013 20:53:11 GMT


> On April 15, 2013, 1:44 a.m., Ben Mahler wrote:
> > Hey Brenden, note that if you'd like to speed up the review process, you could split
up the changes you listed in the description into separate reviews.
> > We use a tool to help with doing chained reviews, you can find it here: support/post-reviews.py.
> > Let me know if you'd like to try it out or need any help!
> 
> Brenden Matthews wrote:
>     This is my first time using Review Board, so you'll have to bear with me.  In the
future I'll be sure to split each item into a separate commit.
>     
>     PS: Is there documentation anywhere on how the system is used?  What do 'fixed' and
'drop' mean?
> 
> Ben Mahler wrote:
>     git rebase -i makes it pretty easy to pull apart a commit, I'll leave it up to you,
but IMO it will be easier / faster for all parties involved :)

Do you want me to close this issue and re-open separate ones?


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10346/#review19146
-----------------------------------------------------------


On April 9, 2013, 10:36 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10346/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 10:36 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
>     - Added CDH4.2.0 support to TUTORIAL.sh
>     - Fixed Hadoop dist extraction in launcher
>     - Add pre/post packaging hooks to TUTORIAL.sh
>     - Don't run the jobtracker at the end by default if ${SKIP_TESTS}
>       defined
> 
> 
> Diffs
> -----
> 
>   hadoop/Makefile.am bd8919a 
>   hadoop/TUTORIAL.sh f3f3d64 
>   hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch fb8b06b 
>   hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch 8f67ff9 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch 6d31578 
>   hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch PRE-CREATION 
>   hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch PRE-CREATION 
>   src/launcher/launcher.cpp bc50c5f 
> 
> Diff: https://reviews.apache.org/r/10346/diff/
> 
> 
> Testing
> -------
> 
> Works in production on Hadoop at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message