mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Overloaded Duration arithmetic operators +, -, +=, -= in libstout.
Date Mon, 15 Apr 2013 18:55:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10422/#review19209
-----------------------------------------------------------

Ship it!



third_party/libprocess/third_party/stout/tests/duration_tests.cpp
<https://reviews.apache.org/r/10422/#comment39782>

    No need to store this, can you just use Hours(3) inline in the comparisons?



third_party/libprocess/third_party/stout/tests/duration_tests.cpp
<https://reviews.apache.org/r/10422/#comment39783>

    EXPECT_SOME_EQ?



third_party/libprocess/third_party/stout/tests/duration_tests.cpp
<https://reviews.apache.org/r/10422/#comment39784>

    Ditto.


- Ben Mahler


On April 15, 2013, 6:25 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10422/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 6:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663

>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp c8d9bbe4c5b1396d2cf6afca2d6bf30e36815c48

> 
> Diff: https://reviews.apache.org/r/10422/diff/
> 
> 
> Testing
> -------
> 
> make check GTEST_FILTER="DurationTest.Test"
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message