mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request: Change Clock::advance() and Clock::update() to use Duration.
Date Fri, 12 Apr 2013 18:31:20 GMT


> On April 12, 2013, midnight, Ben Mahler wrote:
> > third_party/libprocess/src/process.cpp, line 578
> > <https://reviews.apache.org/r/10421/diff/1/?file=280462#file280462line578>
> >
> >     I wonder why 9 was used in these.. can you update these to:
> >     
> >     std::setprecision(std::numeric_limits<double>::digits10 + 1)
> >     
> >     If you want a little background:
> >     http://stackoverflow.com/questions/554063/how-do-i-print-a-double-value-with-full-precision-using-cout

I think "std::numeric_limits<double>::digits10 + 1" == 16 here, do we want to output
the full precision?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10421/#review19043
-----------------------------------------------------------


On April 11, 2013, 7:10 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10421/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
>   src/tests/gc_tests.cpp 8c2e6e137748b9c8fa3db826752bed6a03c6c92f 
>   src/tests/log_tests.cpp a0a4b4aea4d47b83f14f140523d0e7317f069a63 
>   src/tests/master_tests.cpp 1581abcd7e2775672c5cde14cb1052ced5f34376 
>   src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
>   src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
>   src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
>   src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e

>   src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef 
>   third_party/libprocess/include/process/clock.hpp be96a68de7257f0ec0a292be1f3357d089397a51

>   third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96 
>   third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84

>   third_party/libprocess/src/tests/statistics_tests.cpp 6efcc8004fc637e5c4dc8f0ba0e34c0a06a8c052

> 
> Diff: https://reviews.apache.org/r/10421/diff/
> 
> 
> Testing
> -------
> 
> make check. 
> Stopped at AllocatorZooKeeperTest, the same place where trunk failed.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message