mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Ash" <and...@andrewash.com>
Subject Re: Review Request: Ignore commented lines in slaves/masters files
Date Wed, 03 Apr 2013 19:08:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10244/
-----------------------------------------------------------

(Updated April 3, 2013, 7:08 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

How does this look?  I removed the whitespace stuff from the regex because I realized it doesn't
really add any flexibility -- you really ought to have the # at the start of the line anyway


Description
-------

Ignore commented lines in slaves/masters files

Commented-out lines are those that are prefixed with a hash '#'


Diffs (updated)
-----

  src/deploy/mesos-start-masters.sh.in d9833c39b0c6e9b8e9e1b9757a7486d852688643 
  src/deploy/mesos-start-slaves.sh.in 4f33babc7d72119b7bf10d394f5982c65360fc8b 
  src/deploy/mesos-stop-masters.sh.in 6800c19bccc4b93b4294b929328495b26d0f4ca0 
  src/deploy/mesos-stop-slaves.sh.in e622eb0e9a23c7c095ccfa4da790c0f2cc8f7fc5 

Diff: https://reviews.apache.org/r/10244/diff/


Testing
-------


Thanks,

Andrew Ash


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message