mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Clean up HierarchicalAllocatorProcess code
Date Tue, 12 Mar 2013 21:26:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/#review17760
-----------------------------------------------------------

Ship it!


Also, if you're worried about performance, feel free to re-run your performance test to check
for regressions!

- Ben Mahler


On March 12, 2013, 8:58 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6665/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 8:58 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots
of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves.
This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping
ids to structs containing the appropriate attributes. The patch also introduces an allocator
namespace.
> 
> 
> Diffs
> -----
> 
>   src/local/local.hpp 2633d25 
>   src/local/local.cpp 3402029 
>   src/master/allocator.hpp b68b67d 
>   src/master/drf_sorter.hpp 79566cc 
>   src/master/drf_sorter.cpp fe31a00 
>   src/master/hierarchical_allocator_process.hpp c1d6f54 
>   src/master/main.cpp ca0abec 
>   src/master/master.hpp c9b4b3f 
>   src/master/master.cpp 814a6e1 
>   src/master/sorter.hpp 73db6b1 
>   src/tests/allocator_tests.cpp b953cd1 
>   src/tests/allocator_zookeeper_tests.cpp 3f70202 
>   src/tests/fault_tolerance_tests.cpp 61509f1 
>   src/tests/gc_tests.cpp fbdd6d6 
>   src/tests/master_detector_tests.cpp 787ba19 
>   src/tests/master_tests.cpp 2ba14fc 
>   src/tests/resource_offers_tests.cpp 44eaf0d 
>   src/tests/sorter_tests.cpp 61e6038 
>   src/tests/utils.hpp d3efa58 
>   third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d 
> 
> Diff: https://reviews.apache.org/r/6665/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message