mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Renamed IsolationModule to Isolator.
Date Tue, 12 Mar 2013 18:22:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9826/#review17745
-----------------------------------------------------------



src/local/local.cpp
<https://reviews.apache.org/r/9826/#comment37661>

    can you do a grep for "module", "isolation", to catch all these old comments too?


- Ben Mahler


On March 8, 2013, 9:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9826/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 9:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> This also kills rotting code, including the "isolation module factory", solaris stuff,
and lxc.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f7242a7fb55de3d1df4930126345274124331d57 
>   src/local/local.cpp 3402029e07341212717e346a97e7cd30fa52ed51 
>   src/slave/cgroups_isolation_module.hpp 11244802b3210ef1a6900b978faf8bbcaa00266c 
>   src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 
>   src/slave/cgroups_isolator.hpp PRE-CREATION 
>   src/slave/cgroups_isolator.cpp PRE-CREATION 
>   src/slave/isolation_module.hpp d7cc02b8ea0cde591ee61059efd79fbacaa74769 
>   src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11 
>   src/slave/isolation_module_factory.hpp 9e1fef4324b6657f9887d2703be4a3257ab71f85 
>   src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c 
>   src/slave/isolator.hpp PRE-CREATION 
>   src/slave/isolator.cpp PRE-CREATION 
>   src/slave/lxc_isolation_module.hpp 6be99038fb547e43e74ef5469f2339bbe82017cf 
>   src/slave/lxc_isolation_module.cpp 1ed3c87f884089e032bba2ed89be109abe6c1c13 
>   src/slave/main.cpp fd338662e3d63e6e683347179b80e07e178b6c98 
>   src/slave/monitor.hpp 9fd92dc05524fb03728ae082e83b3fd9736d8e84 
>   src/slave/monitor.cpp 56175598efc54c86b868648900ced3eb953522b5 
>   src/slave/process_based_isolation_module.hpp 6a4e6aef9ab4b13cce9341f6f35c6b24e6f8fde7

>   src/slave/process_based_isolation_module.cpp ff98d105af675dfc66070feaa43b42c1aa438fd8

>   src/slave/process_isolator.hpp PRE-CREATION 
>   src/slave/process_isolator.cpp PRE-CREATION 
>   src/slave/projd.cpp 663c531f27da5ff7c4e25aafd8b105492331d203 
>   src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c 
>   src/slave/slave.cpp 889e9fe7671c9b158486fd7b85fef139c4ab8c9b 
>   src/slave/solaris_project_isolation_module.hpp 18c010922231f9c4a7fa90526243ea00ce83e55e

>   src/slave/solaris_project_isolation_module.cpp f3b6a68926af34c46873d8de1c9858480f42ef98

>   src/tests/allocator_tests.cpp b953cd1b4a772a5de956d1354eafa6dd23bdd4ca 
>   src/tests/allocator_zookeeper_tests.cpp 3f7020290029f28ab9237b2941c4977ca496fbe7 
>   src/tests/cgroups_isolation_tests.cpp 2fb620789d19c17082a305981bfe26122e5f25f2 
>   src/tests/cgroups_isolator_tests.cpp PRE-CREATION 
>   src/tests/exception_tests.cpp 31abb93bd92324194ee3ac272424a5937eacacb9 
>   src/tests/fault_tolerance_tests.cpp 61509f1c2432dcd1d0c5d1be1e662aff76a29fd5 
>   src/tests/gc_tests.cpp fbdd6d650751dd1ef241c86bcee8a383d73d9a4b 
>   src/tests/master_detector_tests.cpp 787ba192d187b7829053450867e05850fa8b862f 
>   src/tests/master_tests.cpp 2ba14fcaade0580970196f0eb8dbcd5ce573797e 
>   src/tests/monitor_tests.cpp 0549616800c249c32ae988c3b483da911f8fa6e2 
>   src/tests/resource_offers_tests.cpp 44eaf0d262e8ae57c5aa5c0f00f1755311533608 
>   src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 
> 
> Diff: https://reviews.apache.org/r/9826/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message