mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fixed initialization of slave resources
Date Thu, 21 Feb 2013 20:43:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8171/#review16878
-----------------------------------------------------------

Ship it!



third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8171/#comment35812>

    Ideally we'd explicitly call this out with ifdefs then. I assume pre 2.3.23 'totalram'
was already in bytes?


- Benjamin Hindman


On Feb. 21, 2013, 7:40 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8171/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 7:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Now we properly set cpu/mem/disk/ports based on what's missing in slave flags.
> 
> Also moved usage from os to fs.
> 
> 
> This addresses bug MESOS-318.
>     https://issues.apache.org/jira/browse/MESOS-318
> 
> 
> Diffs
> -----
> 
>   src/common/resources.hpp 7e71a58cb601f1626872baa4908cd5d0d838ca0e 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd 
>   src/tests/exception_tests.cpp 13355d08788432ed07679daf24c2d74cc12a7f11 
>   third_party/libprocess/include/stout/fs.hpp 4dedf5522d62b920b859a0a3098571665496ca5c

>   third_party/libprocess/include/stout/os.hpp 32638ee273492550491b85223cda8e7a5bde7fa5

> 
> Diff: https://reviews.apache.org/r/8171/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message