mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Mackey" <>
Subject Review Request: Initial support for CPU limits via CFS Bandwidth Control.
Date Fri, 15 Feb 2013 06:42:15 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups.

CFS is unique relative to existing Mesos cgroups support in that it is a "subfeature" of an
already supported cgroups subsystem, cpu. Also, there are two "tunables" for configuring CFS
bandwidth limiting.

There are 4 approaches one could take:
1) Use the CFS bandwidth limiting if the feature is present
2) Expose as separate flag, eg "cpu,cfs,memory,freezer"
3) Add feature flag support to subsystems via an additional delimiter, eg "cpu+cfs,memory,freezer".

4) Add an additional control flag via some other means

Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a cgroups resource
Option 3's downside is it greatly increases complexity of parsing cgroups subsystem flags.

This diff takes option 1. 

This addresses bug MESOS-315.


  src/slave/cgroups_isolation_module.cpp 14f549e 



make check + additional testing


David Mackey

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message