mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Added stout Error and None (w/ tests).
Date Fri, 08 Feb 2013 05:48:36 GMT


> On Feb. 5, 2013, 10:38 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/stout/error.hpp, line 15
> > <https://reviews.apache.org/r/9304/diff/1/?file=255490#file255490line15>
> >
> >     You shouldn't use "of course" and "probably" (3 times) in the same sentence
:) The former indicates you are confident, the latter indicates you are not.
> >     
> >     s/Of course, performance/Performance/

;)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9304/#review16142
-----------------------------------------------------------


On Feb. 8, 2013, 5:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9304/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 5:48 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/stout_tests.cpp fffef3e42774e9b090a098a219a92e642d303d27 
>   third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 
>   third_party/libprocess/include/stout/error.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9304/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message