mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Fix proxy scheduler/executor build warnings.
Date Thu, 07 Feb 2013 00:51:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16229
-----------------------------------------------------------



src/python/native/proxy_executor.cpp
<https://reviews.apache.org/r/9320/#comment34684>

    periods at the end of sentences.



src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/9320/#comment34685>

    ditto


- Vinod Kone


On Feb. 7, 2013, 12:48 a.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Python.h is a finicky header file. Include it before iostream.
> 
> Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files
> 
> 
> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> 
> 
> Diffs
> -----
> 
>   src/python/native/proxy_executor.cpp 2767e0a 
>   src/python/native/proxy_scheduler.cpp 8bf368d 
> 
> Diff: https://reviews.apache.org/r/9320/diff/
> 
> 
> Testing
> -------
> 
> make check passes.
> 
> 
> Thanks,
> 
> David Mackey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message