From mesos-dev-return-5048-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org Thu Jan 3 18:53:32 2013 Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C65B97E2 for ; Thu, 3 Jan 2013 18:53:32 +0000 (UTC) Received: (qmail 3696 invoked by uid 500); 3 Jan 2013 18:53:32 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 3659 invoked by uid 500); 3 Jan 2013 18:53:32 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 3647 invoked by uid 99); 3 Jan 2013 18:53:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2013 18:53:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B249D1C5EEC; Thu, 3 Jan 2013 18:53:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0221520641755041602==" MIME-Version: 1.0 Subject: Re: Review Request: Moved stout tests into libprocess. From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Thu, 03 Jan 2013 18:53:26 -0000 Message-ID: <20130103185326.29907.69194@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8794/ X-Sender: "Vinod Kone" References: <20130102024521.29903.24085@reviews.apache.org> In-Reply-To: <20130102024521.29903.24085@reviews.apache.org> Reply-To: "Vinod Kone" --===============0221520641755041602== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8794/#review15036 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On Jan. 2, 2013, 2:45 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8794/ > ----------------------------------------------------------- > = > (Updated Jan. 2, 2013, 2:45 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > This is part 3 of my test refactorings to pull apart the libprocess / sto= ut tests. > = > This moves the stout tests into third_party/libprocess/tests. > I added an assert.hpp file as well so that the libprocess tests can share= the ASSERT_SOME style asserts. > There are no actual diffs to the test file contents. > = > = > Diffs > ----- > = > src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 = > src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3 = > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed9013= 0099 = > third_party/libprocess/src/tests/assert.hpp PRE-CREATION = > third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION = > = > Diff: https://reviews.apache.org/r/8794/diff/ > = > = > Testing > ------- > = > make check > cd third_party/libprocess > make check > = > = > Thanks, > = > Ben Mahler > = > --===============0221520641755041602==--