mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Refactored protobuf read() to return the protobuf.
Date Wed, 30 Jan 2013 19:55:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8696/#review15877
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8696/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is a cleaner way to expose protobuf reads.
> 
> Simplifies the signature and the state space of possible results returning from the read.
> 
> 
> Diffs
> -----
> 
>   src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0

> 
> Diff: https://reviews.apache.org/r/8696/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message