mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fixed os read / write calls to be POSIX compliant (handle 0, EINTR, and partial reads / writes).
Date Wed, 30 Jan 2013 19:54:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/#review15808
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/8694/#comment34049>

    By our objective and irrefutable assessment metric known as "jaggedness", I argue the
original formatting was better! ;)



src/master/master.cpp
<https://reviews.apache.org/r/8694/#comment34050>

    I like this one better though!



third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8694/#comment34052>

    It's unclear whether or not we'll always be able to restore the offset, so we probably
shouldn't expose the semantics as such so people don't expect it.


- Benjamin Hindman


On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8694/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> All is well in the world again.
> This bug manifested when I was fixing MESOS-326.
> 
> 
> This addresses bug MESOS-319.
>     https://issues.apache.org/jira/browse/MESOS-319
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c 
>   src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e 
>   src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3 
>   third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95

> 
> Diff: https://reviews.apache.org/r/8694/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message