mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fixed protobuf read / write calls to be POSIX compliant (handle 0, EINTR, and partial reads / writes).
Date Wed, 30 Jan 2013 19:51:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8695/#review15869
-----------------------------------------------------------



third_party/libprocess/include/stout/protobuf.hpp
<https://reviews.apache.org/r/8695/#comment34150>

    Historically these collection of functions always tried to restore the offset if a read
"failed" (or was none before the change to os::read). You don't do that here but you still
do it below. We probably can't reliably restore the offset, so we shouldn't even bother trying.



third_party/libprocess/include/stout/protobuf.hpp
<https://reviews.apache.org/r/8695/#comment34156>

    The 'parsed' boolean was pulled out to enable deleting the temporary array no matter what
instead of  duplicating the delete within the if branch and outside, but since you don't need
to do that anymore, we can just kill it.



third_party/libprocess/include/stout/protobuf.hpp
<https://reviews.apache.org/r/8695/#comment34155>

    Do they say this in the documentation? If not, this is a brittle thing to rely on and
not worth it in my opinion.


- Benjamin Hindman


On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8695/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Please review this first: https://reviews.apache.org/r/8694/
> 
> All is well in the world again.
> 
> 
> This addresses bug MESOS-319.
>     https://issues.apache.org/jira/browse/MESOS-319
> 
> 
> Diffs
> -----
> 
>   src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e 
>   src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9 
>   third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe41566e968c0be805c276e0

> 
> Diff: https://reviews.apache.org/r/8695/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message